Skip to content

Allow const parameters in for<> #1907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 15, 2025
+6 −21
Merged

Allow const parameters in for<> #1907

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 1 addition & 17 deletions src/generics.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -671,23 +671,7 @@ pub(crate) mod parsing {
lifetimes: {
let mut lifetimes = Punctuated::new();
while !input.peek(Token![>]) {
let attrs = input.call(Attribute::parse_outer)?;

let lookahead = input.lookahead1();
if lookahead.peek(Lifetime) {
lifetimes.push_value(GenericParam::Lifetime(LifetimeParam {
attrs,
..input.parse()?
}));
} else if cfg!(feature = "full") && lookahead.peek(Ident) {
lifetimes.push_value(GenericParam::Type(TypeParam {
attrs,
..input.parse()?
}));
} else {
return Err(lookahead.error());
}

lifetimes.push_value(input.parse()?);
if input.peek(Token![>]) {
break;
}
Expand Down
9 changes: 5 additions & 4 deletions tests/repo/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,11 @@ const REVISION: &str = "3672a55b7cfd0a12e7097197b6242872473ffaa7";

#[rustfmt::skip]
static EXCLUDE_FILES: &[&str] = &[
// TODO: non-lifetime binders on closures: `let _ = for<T> || {}`
// https://github.com/dtolnay/syn/issues/1906
"src/tools/rustfmt/tests/target/non-lifetime-binders.rs",
"src/tools/rustfmt/tests/source/non-lifetime-binders.rs",

// TODO: const traits: `pub const trait Trait {}`
// https://github.com/dtolnay/syn/issues/1887
"src/tools/clippy/tests/ui/assign_ops.rs",
Expand Down Expand Up @@ -308,10 +313,6 @@ static EXCLUDE_FILES: &[&str] = &[
// Lifetimes and types out of order in angle bracketed path arguments
"tests/ui/parser/constraints-before-generic-args-syntactic-pass.rs",

// Const parameter in lifetime binder: `for<const C: usize> [T; C]: Sized`
"src/tools/rustfmt/tests/target/non-lifetime-binders.rs",
"src/tools/rustfmt/tests/source/non-lifetime-binders.rs",

// Deprecated anonymous parameter syntax in traits
"src/tools/rustfmt/tests/source/trait.rs",
"src/tools/rustfmt/tests/target/trait.rs",
Expand Down
Loading