Skip to content

Add code coverage support in pipeline - Fixes #61 #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 24, 2021

Conversation

PlagueHO
Copy link
Member

@PlagueHO PlagueHO commented Apr 22, 2021

Pull Request (PR) description

This PR adds support for code coverage reporting in the pipeline and updates to use Sampler GitHub tasks.

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry under the Unreleased section of the change log in the CHANGELOG.md.
    Entry should say what was changed, and how that affects users (if applicable).
  • Resource documentation added/updated in README.md in resource folder.
  • Resource parameter descriptions added/updated in schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Resource Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
  • New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

@johlju - would you mind reviewing when you have time?


This change is Reviewable

@PlagueHO PlagueHO added the needs review The pull request needs a code review. label Apr 22, 2021
Copy link
Member

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 6 of 6 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @PlagueHO)

@johlju johlju removed the needs review The pull request needs a code review. label Apr 22, 2021
Copy link
Member

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @PlagueHO)


azure-pipelines.yml, line 86 at r1 (raw file):

- job: Test_Unit_2016

This job is not uploading the test artifact, so the pipeline fails.

@codecov
Copy link

codecov bot commented Apr 23, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@415a771). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff          @@
##             main   #62   +/-   ##
====================================
  Coverage        ?   95%           
====================================
  Files           ?     4           
  Lines           ?   264           
  Branches        ?     0           
====================================
  Hits            ?   253           
  Misses          ?    11           
  Partials        ?     0           

Copy link
Member Author

@PlagueHO PlagueHO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could review again @johlju ? Thankk you!

Reviewable status: 5 of 6 files reviewed, 1 unresolved discussion (waiting on @johlju)


azure-pipelines.yml, line 86 at r1 (raw file):

Previously, johlju (Johan Ljunggren) wrote…
- job: Test_Unit_2016

This job is not uploading the test artifact, so the pipeline fails.

Done.

Copy link
Member

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @PlagueHO)

@johlju johlju merged commit 076ab61 into dsccommunity:main Apr 24, 2021
@PlagueHO PlagueHO deleted the Issue-61 branch April 24, 2021 09:17
mkht pushed a commit to mkht/FileContentDsc that referenced this pull request Oct 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable Code Coverage Reporting Update Sampler Build Tasks
2 participants