-
Notifications
You must be signed in to change notification settings - Fork 56
DSC_DNSServerStubZone: Added a new resource to manage file-backed DNS Stub Zones #276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
First time doing a pull request on any GitHub project, so I expect I'll have missed some things. Also, not sure if this project is still active. If so, I'll invest the time in figuring out the test requirements. |
Happy to have you here and for you to contribute. It is active. Seems the pipeline needs updating though but that can happen in another PR, but I ask if someone else in the community can help with that (since I'm out with a cold). Will also ask if someone will help with the review, so in the meantime, look at the tests as we need that to merge. |
@EJansenMSFT, the build failure is due to the schema.mof being not recognized as text or has some strange characters at the beginning. |
source/DSCResources/DSC_DNSServerStubZone/DSC_DnsServerStubZone.psm1
Outdated
Show resolved
Hide resolved
source/DSCResources/DSC_DNSServerStubZone/DSC_DnsServerStubZone.psm1
Outdated
Show resolved
Hide resolved
source/DSCResources/DSC_DNSServerStubZone/DSC_DnsServerStubZone.psm1
Outdated
Show resolved
Hide resolved
source/DSCResources/DSC_DNSServerStubZone/DSC_DnsServerStubZone.psm1
Outdated
Show resolved
Hide resolved
source/DSCResources/DSC_DNSServerStubZone/DSC_DnsServerStubZone.psm1
Outdated
Show resolved
Hide resolved
source/DSCResources/DSC_DNSServerStubZone/DSC_DnsServerStubZone.psm1
Outdated
Show resolved
Hide resolved
source/DSCResources/DSC_DNSServerStubZone/DSC_DnsServerStubZone.psm1
Outdated
Show resolved
Hide resolved
Ah awesome, glad to see the project is still active. Great feedback @indented-automation - I'll fix those this weekend when I get a chance and do an updated commit, which I believe you guys can see without my doing a PR. Still trying to figure it all out - this is day four of trying to learn DSC and day two of Git. |
…e.psm1 Co-authored-by: Chris Dent <[email protected]>
…ill need to test.
Yes, pushing commits to your working branch updates this PR as you figured out. 🙂
You are doing great! We all have been there. 🙂 You should also bring in the latest changes in main. Easiest by clicking on "Update branch" where it says "This branch is out-of-date with the base branch". Then do a |
OK, I think I'm caught up on the code mods. I assume at this point I'd need to figure out the test checkboxes part above and then re-attempt a PR? |
Your schema.mof is corrupt/malformed. It should be plain text. This will correct the build error. |
Hah, I went from passing (Test Unit) by doing nothing, to now failing it after copying / pasting the 'DSC_DNSServerPrimaryZone.Tests.Ps1' creating a 'DSC_DNSServerStubZone.Tests.Ps1' file and modifying it, under Test\Unit. |
You can either read the logs output on Azure DevOps or for a better/faster experience you can test locally. First download the modules - If you make a source change then you need to run - You can then run unit tests with - To run HQRM tests : - |
Also, to make things easier comment out the Test and Set in the unit tests and concentrate on getting the Get working. To really speed things up you can comment out all the other unit tests locally and not have to wait for tests to run. |
Pull Request (PR) description
This Pull Request (PR) fixes the following issues
Task list
file CHANGELOG.md. Entry should say what was changed and how that
affects users (if applicable), and reference the issue being resolved
(if applicable).
and comment-based help.
This change is