Skip to content

DSC_DNSServerStubZone: Added a new resource to manage file-backed DNS Stub Zones #276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

EJansenMSFT
Copy link

@EJansenMSFT EJansenMSFT commented Apr 10, 2025

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Resource documentation added/updated in README.md.
  • Resource parameter descriptions added/updated in README.md, schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Community Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Community Testing Guidelines.
  • New/changed code adheres to DSC Community Style Guidelines.

This change is Reviewable

@EJansenMSFT
Copy link
Author

EJansenMSFT commented Apr 10, 2025

First time doing a pull request on any GitHub project, so I expect I'll have missed some things. Also, not sure if this project is still active. If so, I'll invest the time in figuring out the test requirements.

@johlju
Copy link
Member

johlju commented Apr 12, 2025

Happy to have you here and for you to contribute. It is active. Seems the pipeline needs updating though but that can happen in another PR, but I ask if someone else in the community can help with that (since I'm out with a cold). Will also ask if someone will help with the review, so in the meantime, look at the tests as we need that to merge.

@dan-hughes
Copy link
Contributor

@EJansenMSFT, the build failure is due to the schema.mof being not recognized as text or has some strange characters at the beginning.

@EJansenMSFT
Copy link
Author

EJansenMSFT commented Apr 12, 2025

Ah awesome, glad to see the project is still active.

Great feedback @indented-automation - I'll fix those this weekend when I get a chance and do an updated commit, which I believe you guys can see without my doing a PR.

Still trying to figure it all out - this is day four of trying to learn DSC and day two of Git.

@johlju
Copy link
Member

johlju commented Apr 13, 2025

which I believe you guys can see without my doing a PR

Yes, pushing commits to your working branch updates this PR as you figured out. 🙂

Still trying to figure it all out - this is day four of trying to learn DSC and day two of Git.

You are doing great! We all have been there. 🙂

You should also bring in the latest changes in main. Easiest by clicking on "Update branch" where it says "This branch is out-of-date with the base branch". Then do a git pull in your local working branch to get the same changes brought locally.

@EJansenMSFT
Copy link
Author

OK, I think I'm caught up on the code mods. I assume at this point I'd need to figure out the test checkboxes part above and then re-attempt a PR?

@dan-hughes
Copy link
Contributor

Your schema.mof is corrupt/malformed. It should be plain text. This will correct the build error.

@EJansenMSFT
Copy link
Author

Hah, I went from passing (Test Unit) by doing nothing, to now failing it after copying / pasting the 'DSC_DNSServerPrimaryZone.Tests.Ps1' creating a 'DSC_DNSServerStubZone.Tests.Ps1' file and modifying it, under Test\Unit.

@dan-hughes
Copy link
Contributor

You can either read the logs output on Azure DevOps or for a better/faster experience you can test locally.

First download the modules - .\build.ps1 -Task noop -ResolveDependency (this only needs to be run once typically)

If you make a source change then you need to run - .\build.ps1 -Task build

You can then run unit tests with - .\build.ps1 -Task test NOTE: you will need to open a new PowerShell window each time you want to test as the old classes are cached.

To run HQRM tests : - .\build.ps1 -Task hqrmtest NOTE: this needs to be run in a PS5 session.

@dan-hughes
Copy link
Contributor

Also, to make things easier comment out the Test and Set in the unit tests and concentrate on getting the Get working.

To really speed things up you can comment out all the other unit tests locally and not have to wait for tests to run.

@johlju johlju added the waiting for code fix A review left open comments, and the pull request is waiting for changes to be pushed by the author. label Jul 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting for code fix A review left open comments, and the pull request is waiting for changes to be pushed by the author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants