Wip 418 error handling #319
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return metadata | ||
|
|
||
| raise_error(res) | ||
| return flow( |
There was a problem hiding this comment.
it looks much better indeed
| "imputer_strategy": imputer_strategy, | ||
| }, | ||
| DiffPrivLibRequestModel.model_validate, | ||
| partial(self.http_client.post, "estimate_diffprivlib_cost"), |
There was a problem hiding this comment.
no more bind(parse_if_OK) ?
There was a problem hiding this comment.
theses are waiting for 202_ACCEPTED, and handled in validate_model_response, but it could be easier to follow if extracted, I'll have a look
|
I think it's great ! I also think it is better if we hide all this from the user perspective because it might be too much as they are usually not proficient with python |
bstuder
force-pushed
the
wip-418-error-handling
branch
2 times, most recently
from
c1905b7 to
6d85f28
Compare
bstuder
force-pushed
the
wip-418-error-handling
branch
2 times, most recently
from
8cf7266 to
bde9162
Compare
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
bstuder
force-pushed
the
wip-418-error-handling
branch
from
4268bad to
c44e3ea
Compare
bstuder
force-pushed
the
wip-418-error-handling
branch
2 times, most recently
from
74eb019 to
9883c17
Compare
bstuder
force-pushed
the
wip-418-error-handling
branch
from
095106d to
441c82f
Compare
bstuder
force-pushed
the
wip-418-error-handling
branch
from
441c82f to
cb7c0d1
Compare
bstuder
force-pushed
the
wip-418-error-handling
branch
from
d051d65 to
25c694b
Compare
bstuder
force-pushed
the
wip-418-error-handling
branch
from
25c694b to
a33a056
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per request.