GitHub actions #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsander
force-pushed
the
github-actions
branch
8 times, most recently
from
be731af to
7d91036
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
lib/pronto/bitbucket.rb
Outdated
| end | ||
| end | ||
| end | ||
|
|
There was a problem hiding this comment.
Layout/TrailingEmptyLines: 2 trailing blank lines detected.
dsander
force-pushed
the
github-actions
branch
4 times, most recently
from
42a88c2 to
b457728
Compare
pronto.gemspec
Outdated
| s.add_development_dependency('rspec-expectations', '~> 3.4') | ||
| s.add_development_dependency('rubocop', '~> 0.58') | ||
| s.add_development_dependency('simplecov', '~> 0.14') | ||
| s.add_development_dependency('simplecov', '~> 0.14', '!= 0.19.1', '!= 0.19.0', '!= 0.18.5', '!= 0.18.4', '!= 0.18.3', '!= 0.18.2', '!= 0.18.1', '!= 0.18.0') |
There was a problem hiding this comment.
Layout/LineLength: Line is too long. [158/120]
dsander
force-pushed
the
github-actions
branch
3 times, most recently
from
4f32cec to
a61d6f9
Compare
dsander
force-pushed
the
github-actions
branch
3 times, most recently
from
de7f755 to
4e85f59
Compare
Ruby 2.3 has some strange openssl version mismatch issue on GitHub Actions. The `rugged` gem itself installs fine but when it loads it's C extensions it somehow loads the wrong openssl version. Running the specs interactively (even on GitHub Actions) works without issues. For this reason Ruby 2.3 is excluded from version the matrix.
dsander
force-pushed
the
github-actions
branch
from
4e85f59 to
245ea0f
Compare
On Ruby 2.4 simplecov 0.18 is installed which [isn't supported by CodeClimate][1]. This [was also broken on master][2]. [1]: https://docs.codeclimate.com/docs/configuring-test-coverage [2]: https://travis-ci.org/github/prontolabs/pronto/jobs/748290009#L1025 Co-authored-by: Ashish Kulkarni <[email protected]>
This ensures the action also runs on pull requests from forks https://docs.github.com/en/actions/reference/events-that-trigger-workflows#pull_request_target
dsander
force-pushed
the
github-actions
branch
from
245ea0f to
2861ac5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.