feat: [CI-16478]: Add Azure Container Registry (ACR) authentication support #480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmd/drone-acr/main.go
Outdated
| } | ||
|
|
||
| const ( | ||
| acrCertPath = "/tmp/acr-cert.pem" |
There was a problem hiding this comment.
Does this work for Windows?
There was a problem hiding this comment.
good catch! I'll change it to use os.TempDir() to keep it more generic and cross platform
jamie-harness
approved these changes
Mar 24, 2025
jamie-harness
approved these changes
Mar 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements Azure Container Registry (ACR) authentication using service principal credentials. This change:
Test Execution LINK