Skip to content

Addl loop prevention for traverse_parent_state #1414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 22, 2019

Conversation

mstemm
Copy link
Contributor

@mstemm mstemm commented May 22, 2019

Add some additional ways to prevent potential loops when traversing
parent state:

  • If the slow threadinfo ever has a tid of -1, stop.
  • If the slow threadinfo ever has ptid == tid, declare a loop and stop.

Add some additional ways to prevent potential loops when traversing
parent state:

 - If the slow threadinfo ever has a tid of -1, stop.
 - If the slow threadinfo ever has ptid == tid, declare a loop and stop.
@mstemm mstemm requested a review from gnosek May 22, 2019 15:05
Include current pointer's tid/ptid.
Copy link
Contributor

@gnosek gnosek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mstemm mstemm merged commit 0c52d1a into dev May 22, 2019
@mstemm mstemm deleted the thread-traversal-sanity-checking branch May 22, 2019 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants