Don't enqueue an async request when there's one already active #1378
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adalton
approved these changes
Apr 26, 2019
If an async lookup is in progress, the lookup key is already removed from m_request_set but it's still present in m_value_map, so a subsequent call to lookup() with the same key will do the same lookup again. Also, when the request had a callback set, upon success we will remove the value from m_value_map, _including the callback_, so the duplicate lookup will store the result in m_value_map without calling the callback again. This patch ensures that there's always at most one in flight request for a particular key.
gnosek
force-pushed
the
async-duplicate-requests
branch
from
99389ab to
f27a1e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an async lookup is in progress, the lookup key is already removed
from m_request_set but it's still present in m_value_map, so a subsequent
call to lookup() with the same key will do the same lookup again.
Also, when the request had a callback set, upon success we will remove
the value from m_value_map, including the callback, so the duplicate
lookup will store the result in m_value_map without calling the callback
again.
This patch ensures that there's always at most one in flight request
for a particular key.