Skip to content

SMAGENT-1396 - Async Protobuf Serialization #1346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 15, 2019
Merged

Conversation

adalton
Copy link
Contributor

@adalton adalton commented Mar 26, 2019

This change applies the Interface Segregation Principle to class sinsp so that clients of the get_capture_stats() operation can be exposed only to an interface that exposes that API instead of the full-blown interface of sinsp.

@adalton adalton self-assigned this Mar 26, 2019
@adalton adalton requested review from nathan-b and bryanseay March 26, 2019 19:25
@adalton adalton requested review from nathan-b and gnosek March 26, 2019 20:13
@adalton
Copy link
Contributor Author

adalton commented Apr 1, 2019

@gnosek @nathan-b Given the nature of this change, I'd like to get a second sign-off before I merge this change. Can one (or both) of you take another look? Thanks!

@adalton adalton force-pushed the async-protobuf-serialization branch from 1b887ff to be5f3a5 Compare April 1, 2019 19:27
@adalton adalton force-pushed the async-protobuf-serialization branch from be5f3a5 to 2b006ca Compare April 12, 2019 13:54
@adalton adalton merged commit 1c3352d into dev Apr 15, 2019
@adalton adalton deleted the async-protobuf-serialization branch April 15, 2019 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants