SMAGENT-1297: Rebuild gcc-plugins before building kernel module #1305
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RHEL kernel sources come with a shared library, stackleak_plugin.so, that we fail to link against because of missing symbols. This change triggers a rebuild of that library before we try to build the kernel module.
bertocci
reviewed
Feb 2, 2019
anoop-sysd
approved these changes
Feb 2, 2019
added 2 commits
February 4, 2019 12:45
This change incorporates a review comment from Brett to rebuild the plugins if the <kernel_dir>/scripts/gcc-plugins directory exists.
The existance of <kernel_src>/scripts/gcc-plugins isn't enough to know if a rebuild is necessary. This change updates build-probe-binaries to rebuild only if stackleak_plugin.so exists in that directory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RHEL kernel sources come with a shared library, stackleak_plugin.so,
that we fail to link against because of missing symbols. This change
triggers a rebuild of that library before we try to build the kernel
module.