Fix off-by-one error with loginuid extract #1227
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The number of params for the execve event is 19 with the loginuid being the last param, so the check should be > 18. Extracting param 18 (which is 0-based indexing into the array of params) is still correct.
mattpag
force-pushed
the
fix-loginuid-extract
branch
from
819b21e to
cee2b96
Compare
|
The fix is right. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The number of params for the execve event is 19 with the loginuid being
the last param, so the check should be > 18. Extracting param 18 (which
is 0-based indexing into the array of params) is still correct.
An example of a trace file that crashes sysdig/falco without this fix is
system-binaries-network-activity.scapin the traces-positive tarball for falco.@mattpag can you take a look?