server(bug): fix json mget crash on invalid path #4940
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: adi_holden <[email protected]>
kostasrim
previously approved these changes
Apr 15, 2025
| @@ -1274,6 +1274,8 @@ std::vector<std::optional<std::string>> OpJsonMGet(const WrappedJsonPath& json_p | |||
| json_val, std::move(cb), CallbackResultOptions::DefaultEvaluateOptions()); | |||
|
|
|||
| if (eval_result.IsV1()) { | |||
| if (eval_result.Empty()) | |||
There was a problem hiding this comment.
May be we should also return nullopt for V2. Let me check
There was a problem hiding this comment.
Yes, we now have the correct behavior:
snippet from redis:
127.0.0.1:6379> json.set json1 . '{"text":"some text"}'
OK
127.0.0.1:6379> json.set json2 . '{"text":"another text"}'
OK
127.0.0.1:6379> json.mget json1 json2 .[0]
1) (nil)
2) (nil)
127.0.0.1:6379> json.mget json1 json2 $.[0]
1) "[]"
2) "[]"
Signed-off-by: adi_holden <[email protected]>
Signed-off-by: adi_holden <[email protected]>
|
You just need to update output of the Json mget command. It skips for now nullable values |
Signed-off-by: adi_holden <[email protected]>
BagritsevichStepan
approved these changes
Apr 15, 2025
romange
pushed a commit
that referenced
this pull request
Apr 17, 2025
* server: fix json mget crash on invalid path --------- Signed-off-by: adi_holden <[email protected]>
romange
pushed a commit
that referenced
this pull request
Apr 17, 2025
* server: fix json mget crash on invalid path --------- Signed-off-by: adi_holden <[email protected]>
kostasrim
pushed a commit
that referenced
this pull request
Apr 22, 2025
* server: fix json mget crash on invalid path --------- Signed-off-by: adi_holden <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4936