fix: '@text:prefix*' matching for fields. #4868
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vyavdoshenko
changed the title
7 tasks
vyavdoshenko
changed the title
| dq \" | ||
| sq \' | ||
| esc_chars ['"\?\\abfnrtv] | ||
| esc_seq \\{esc_chars} | ||
| term_char [_]|\w |
There was a problem hiding this comment.
why did you remove this?
There was a problem hiding this comment.
Because \w has [ _ ] as part of its rule.
It duplicates it. It's useless, at least.
| %} | ||
|
|
||
| blank [ \t\r] |
There was a problem hiding this comment.
This rule is useless.
There is no place where it is used.
| @@ -191,6 +191,36 @@ TEST_F(SearchParserTest, Scanner) { | |||
| NEXT_EQ(TOK_DOUBLE, string, "33.3"); | |||
| } | |||
|
|
|||
| TEST_F(SearchParserTest, EscapedTagPrefixes) { | |||
There was a problem hiding this comment.
We need also add tests for that to the search_family_test
You can just copy snippet from the user's issue
src/core/search/lexer.lex
Outdated
| @@ -77,6 +77,7 @@ tag_val_char {term_char}|\\[,.<>{}\[\]\\\"\':;!@#$%^&*()\-+=~\/ ] | |||
| {term_char}+"*" return Parser::make_PREFIX(str(), loc()); | |||
There was a problem hiding this comment.
we have now two times + "*"
consider add a variable for *. And may be join this to methods (if possible)
BagritsevichStepan
approved these changes
Apr 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: Pattern matching error when query includes escaped special characters #4691