chore(cluster_mgr): introduce SlotRange class #4814
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romange
force-pushed
the
Pr2
branch
2 times, most recently
from
b83be3c to
920d1ad
Compare
Before: slot merging/splitting logic was mixed with business logic. Also, slots were represented as dictionary, which made the code less readable. Now, SlotRange handles the low-level logic, which makes the high-level code simpler to understand. Signed-off-by: Roman Gershman <[email protected]>
BorysTheDev
reviewed
Mar 23, 2025
Comment on lines
+104
to
+114
| def split(self, slot_id): | ||
| assert self.contains(slot_id) | ||
|
|
||
| if self.start < self.end: | ||
| if slot_id == self.start: | ||
| return None, SlotRange(self.start + 1, self.end) | ||
| elif slot_id == self.end: | ||
| return SlotRange(self.start, self.end - 1), None | ||
| elif self.start < slot_id < self.end: | ||
| return SlotRange(self.start, slot_id - 1), SlotRange(slot_id + 1, self.end) | ||
| return None, None |
There was a problem hiding this comment.
It's better to rename it because we remove the slot and return the left and right range.
Maybe simple remove_slot_id() is enough or at least add a comment
There was a problem hiding this comment.
I will rename if in subsequent PR. My goal is to add the "drop" action to drop slot ranges ( to reproduce flush slots flow).
There was a problem hiding this comment.
And once you drop/flush you can measure :) Nice!
BorysTheDev
approved these changes
Mar 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before: slot merging/splitting logic was mixed with business logic. Also, slots were represented as dictionary, which made the code less readable. Now, SlotRange handles the low-level logic, which makes the high-level code simpler to understand.