chore: Hide managed service info in INFO
#4248
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specifically: * `INFO REPLICATION` does not list the replicas, but does still show `connected_slaves` * `INFO SERVER` does not show `thread_count` and `os` Fixes #4173
kostasrim
approved these changes
Dec 3, 2024
| @@ -2222,10 +2225,12 @@ void ServerFamily::Info(CmdArgList args, const CommandContext& cmd_cntx) { | |||
| append("dragonfly_version", GetVersion()); | |||
| append("redis_mode", GetRedisMode()); | |||
| append("arch_bits", 64); | |||
| append("os", GetOSString()); | |||
| if (!absl::GetFlag(FLAGS_managed_service_info)) { | |||
There was a problem hiding this comment.
We could cache the result of GetFlag :)
There was a problem hiding this comment.
We shouldn't optimize for INFO command in that level, let alone this value can change via CONFIG SET.
There was a problem hiding this comment.
If it can change by CONFIG SET then an INFO ALL might contain some of the changes depending on the GetFlag at that point in time. In other words this is a race (not a data race but a race on what the thread will see when it polls GetFlag twice so the first if might be true while the second false)
There was a problem hiding this comment.
We can surely live our lives with this race 🤣
romange
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically:
INFO REPLICATIONdoes not list the replicas, but does still showconnected_slavesINFO SERVERdoes not showthread_countandosFixes #4173