Skip to content

fix(test): copy logs for failed test during TEARDOWN phase #3331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 17, 2024
Merged

fix(test): copy logs for failed test during TEARDOWN phase #3331

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0f25547
fix(test): copy logs for failed test during TEARDOWN phase
BorysTheDev Jul 17, 2024
3fdf81c
test: add exception to check the fix
BorysTheDev Jul 17, 2024
aecdac1
fix: remove test exception
BorysTheDev Jul 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions tests/dragonfly/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -394,6 +394,8 @@ def pytest_runtest_makereport(item, call):
if report.when == "teardown":
log_dir = getattr(item, "log_dir", None)
call_outcome = getattr(item, "call_outcome", None)
if report.failed:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you plz add a commit that verifies this ? Basically I would like you to test that this work. You can revert this afterwards.

Also if you could add a small description on the PR it would be perfect

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I test it on my PC, but if you want I can do it here too

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just in case, you never know with workflows

copy_failed_logs(log_dir, report)
if call_outcome and call_outcome.failed:
copy_failed_logs(log_dir, call_outcome)

Expand Down