-
Notifications
You must be signed in to change notification settings - Fork 1.1k
feat(test): Improve benchmark workflow #3330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
de82fac
d7f4f71
7591cb5
612eaa9
eb6b3cd
d5de681
50ca6b9
b028a84
ea06fe6
f7a94cb
1020f5d
9039066
2b4ad81
8e096e2
20515fd
cd413df
6c2516b
ae55cd6
95b4d65
c7b9758
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,6 +7,10 @@ def main(): | |
max_unaccounted = 200 * 1024 * 1024 # 200mb | ||
|
||
client = redis.Redis(decode_responses=True) | ||
info = client.info("server") | ||
# Check version upgrade finsihed from last released version to last weekly docker build | ||
assert info["dragonfly_version"] == "df-HEAD-HASH-NOTFOUND" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. So, There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It runs at the end when memtier finish running and also the upgrade was done |
||
|
||
info = client.info("memory") | ||
print(f'Used memory {info["used_memory"]}, rss {info["used_memory_rss"]}') | ||
assert info["used_memory_rss"] - info["used_memory"] < max_unaccounted | ||
|
@@ -26,7 +30,11 @@ def is_zero_lag(replication_state): | |
time.sleep(1) | ||
replication_state = client.info("replication")["slave0"] | ||
|
||
assert replication_state["lag"] == 0, f"Lag is bad, expected 0, got {replication_state['lag']}" | ||
if replication_state["lag"] != 0: | ||
print(f"Lag is bad, expected 0, got {replication_state['lag']}") | ||
info = client.info("all") | ||
print(f"Info all output: {info}") | ||
assert False | ||
|
||
|
||
if __name__ == "__main__": | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed the expiry-range flag as it would create failure in checking the lag between master and replica as entries will continue expire after benchmark finished running