Skip to content

chore: debugging fixes #3275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 7, 2024
Merged

chore: debugging fixes #3275

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/facade/dragonfly_connection.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -748,6 +748,7 @@ std::pair<std::string, std::string> Connection::GetClientInfoBeforeAfterTid() co
string_view phase_name = PHASE_NAMES[phase_];

if (cc_) {
DCHECK(cc_->reply_builder());
string cc_info = service_->GetContextInfo(cc_.get()).Format();
if (cc_->reply_builder()->IsSendActive())
phase_name = "send";
Expand Down Expand Up @@ -1104,6 +1105,8 @@ void Connection::OnBreakCb(int32_t mask) {
return;
}

DCHECK(cc_->reply_builder());

VLOG(1) << "[" << id_ << "] Got event " << mask << " " << phase_ << " "
<< cc_->reply_builder()->IsSendActive() << " " << cc_->reply_builder()->GetError();

Expand Down
2 changes: 1 addition & 1 deletion src/server/rdb_save.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -878,7 +878,7 @@ void SerializerBase::DumpObject(const CompactObj& obj, io::StringSink* out) {
// 1. Save the value itself - without the key
// 2. Save footer: this include the RDB version and the CRC value for the message
auto type = RdbObjectType(obj);
DVLOG(1) << "We are going to dump object type: " << type;
DVLOG(1) << "We are going to dump object type: " << int(type);
std::error_code ec = serializer.WriteOpcode(type);
CHECK(!ec);
ec = serializer.SaveValue(obj);
Expand Down