fix(tiering): update iterator after await throttle #2440
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: adi_holden <[email protected]>
Signed-off-by: adi_holden <[email protected]>
romange
reviewed
Jan 18, 2024
| PrimeTable* pt = db_slice_.GetTables(db_index).first; | ||
| if (!it.IsOccupied() || it->first != key) { | ||
| res_it = pt->Find(key); | ||
| CHECK(!res_it.is_done()); |
There was a problem hiding this comment.
add a comment explaining why this check always holds.
romange
reviewed
Jan 18, 2024
src/server/tiered_storage.h
Outdated
| @@ -50,6 +50,11 @@ class TieredStorage { | |||
|
|
|||
| void WriteSingle(DbIndex db_index, PrimeIterator it, size_t blob_len); | |||
|
|
|||
| // Returns a pair consisting of an bool denoting whether we can write to disk, and updated | |||
| // iterator as this function can yield. | |||
There was a problem hiding this comment.
... 'it' should not be used after the call to this function.
romange
previously approved these changes
Jan 18, 2024
Signed-off-by: adi_holden <[email protected]>
romange
approved these changes
Jan 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.