chore: refactor VersionMonitor into a separate file #2326
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Roman Gershman <[email protected]>
chakaz
previously approved these changes
Dec 21, 2023
adiholden
reviewed
Dec 24, 2023
|
|
||
| // check if it's a production release tag. | ||
| if (GetFlag(FLAGS_version_check) && kGitTag[0] == 'v' && strchr(kGitTag, '-') == nullptr) { | ||
| version_monitor.Run(pool); |
There was a problem hiding this comment.
Are there any changes in the Run function expect from the line above pulled out and moving it to a different file?
Its impossible with github to see if there are any changes in the implementation
There was a problem hiding this comment.
not, it's just moving the same code.
chakaz
approved these changes
Dec 24, 2023
adiholden
approved these changes
Dec 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.