feat(Server):support Verbatim strings resp type, using it for CLIENT LIST and INFO commands #2264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romange
reviewed
Dec 6, 2023
src/facade/reply_builder.cc
Outdated
| DVLOG(1) << "Unknown verbatim reply format: " << format; | ||
| return; | ||
| } | ||
| iovec v[4] = {IoVec(lenpref), IoVec(format_str), IoVec(str), IoVec(kCRLF)}; |
There was a problem hiding this comment.
there is a small preference to reduce number of vectors (it's more efficient).
Therefore, I suggest to increase tmp buffer size to accommodate the format prefix as well.
Signed-off-by: Yue Li <[email protected]>
chakaz
previously approved these changes
Dec 6, 2023
| if (!is_resp3_) | ||
| return SendBulkString(str); | ||
|
|
||
| char tmp[absl::numbers_internal::kFastToBufferSize + 7]; |
There was a problem hiding this comment.
Nit: if you use std::array you'll get out-of-bound checks in debug runs (plus .size() instead of ABSL_ARRAYSIZE)
There was a problem hiding this comment.
i will keep the raw array to be consistent with other places...
romange
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2242 #2253
Reference:
The definition of Redis verbatim strings: https://redis.io/docs/reference/protocol-spec/#verbatim-strings
"For example, the Redis command INFO outputs a report that includes newlines. When using RESP3, redis-cli displays it correctly because it is sent as a Verbatim String reply (with its three bytes being "txt"). When using RESP2, however, the redis-cli is hard-coded to look for the INFO command to ensure its correct display to the user."