feat(server): add pidfile parameter. #216
Conversation
| @@ -199,6 +217,13 @@ Usage: dragonfly [FLAGS] | |||
| CHECK_LT(kver.major, 99u); | |||
| dfly::kernel_version = kver.kernel * 100 + kver.major; | |||
|
|
|||
| string pidfile_path = GetFlag(FLAGS_pidfile); | |||
There was a problem hiding this comment.
the feature is a bit more complicated than that. You also need to remove the file upon exit.
see https://github.com/redis/redis/blob/d00b8af89265c501fb4a0cdd546702b90432a896/src/server.c#L421
for example
There was a problem hiding this comment.
Can you elaborate on your comment here? I'm unsure where to place the file deletion in dfly_main.cc and how to ensure the deletion function will be called at the server exit.
There was a problem hiding this comment.
what you did at lines 265-267 is good. Was it always there? I did not see it before.
There was a problem hiding this comment.
It just added in the latest commit after you asked for the removal of the file upon exit.
src/server/dfly_main.cc
Outdated
| ofs.open(path, ios::trunc); | ||
| ofs << getpid(); | ||
| ofs.close(); | ||
| } catch (ios::failure& ex) { |
There was a problem hiding this comment.
I also do not use c++ exceptions. These are poorly designed in c++ and you can see that I always return errors explicitly.
Signed-off-by: iko1 <[email protected]>
iko1
force-pushed
the
feature/add-pidfile-parameter
branch
from
d18cf06 to
dd3deab
Compare
romange
changed the title
Fixes #209
Signed-off-by: iko1 [email protected]