Skip to content

Conversation

kostasrim
Copy link
Contributor

I disable the flaky ACL tests for now because we now run the regression tests are part of the release build. This will interfere with our release schedule so I am pushing a temporary fix for now.

@kostasrim kostasrim requested a review from dranikpg September 3, 2023 08:35
@kostasrim kostasrim self-assigned this Sep 3, 2023
dranikpg
dranikpg previously approved these changes Sep 3, 2023
Copy link
Contributor

@dranikpg dranikpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can mark them with @pytest.skip()

@kostasrim
Copy link
Contributor Author

@dranikpg lol true

@kostasrim
Copy link
Contributor Author

@dranikpg

image

Copy link
Contributor

@dranikpg dranikpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You didn't even google it and blindly believed me 😆 its pytest.mark.skip I remembered https://docs.pytest.org/en/7.1.x/how-to/skipping.html#skipping-test-functions

@kostasrim
Copy link
Contributor Author

kostasrim commented Sep 3, 2023

You didn't even google it and blindly believed me

Yes 🤣

@kostasrim kostasrim requested a review from dranikpg September 3, 2023 08:59
@kostasrim kostasrim enabled auto-merge (squash) September 3, 2023 09:03
@kostasrim kostasrim merged commit 196650a into main Sep 3, 2023
@kostasrim kostasrim deleted the disable_flaky branch September 3, 2023 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants