fix(ACL): Fix the iteration over categories loop in AclToString #1731
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kostasrim
approved these changes
Aug 24, 2023
| "KEYSPACE", "READ", "WRITE", "SET", "SORTED_SET", "LIST", "HASH", | ||
| "STRING", "BITMAP", "HYPERLOG", "GEO", "STREAM", "PUBSUB", "ADMIN", | ||
| "FAST", "SLOW", "BLOCKING", "DANGEROUS", "CONNECTION", "TRANSACTION", "SCRIPTING", | ||
| "_RESERVED", "_RESERVED", "_RESERVED", "_RESERVED", "_RESERVED", "_RESERVED", "_RESERVED", |
There was a problem hiding this comment.
We should guard against +@_RESERVED but I can handle this case separately since I will make some changes anyway.
There was a problem hiding this comment.
If it's not in the hash table it's fine, no?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The loop had several problems - it's using
stepto access the strings, but the bitfields is not contiguous (there's a jump betweenSCRIPTINGandFT_SEARCH), and it has two off-by-ones (KEYSPACEandJSONare never checked for).