chore: Refactor SortedMap #1666
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dranikpg
previously approved these changes
Aug 8, 2023
dranikpg
previously approved these changes
Aug 8, 2023
1. intoduce variant of Redis and Dragonfly implementation and wrap each operation with a dedicated dispatcher operator. The dragonfly implementation path is a noop and not implemented. 2. Introduce a very basic sorted_map_test around Add and move the unrelated old test from sorted_map_test to bptree_set_test. Signed-off-by: Roman Gershman <[email protected]>
dranikpg
previously approved these changes
Aug 8, 2023
src/core/sorted_map.h
Outdated
Comment on lines
67
to
72
| int Add(double score, sds ele, int in_flags, int* out_flags, double* newscore) { | ||
| return std::visit( | ||
| Overload{[&](RdImpl& impl) { return impl.Add(score, ele, in_flags, out_flags, newscore); }, | ||
| [&](DfImpl& impl) { return impl.Add(score, ele, in_flags, out_flags, newscore); }}, | ||
| impl_); | ||
| } |
There was a problem hiding this comment.
Didn't want to bother you refactoring, but either way... 100LOC less is good 😆
Just a side note, you can use auto-lambdas (template under the hood), so you don't need to type it all out twice, i.e.
visit([](auto& impl) { impl.Add(); }, impl_)There was a problem hiding this comment.
I was not sure I can, I thought this feature actually requires explicit override so it will deduce the base class types. checking it now
There was a problem hiding this comment.
indeed, it works. PTAL
Signed-off-by: Roman Gershman <[email protected]>
dranikpg
approved these changes
Aug 8, 2023
hmm, it won't reduce number of lines, I will leave it as is :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
intoduce variant of Redis and Dragonfly implementation and wrap each operation with a dedicated dispatcher operator. The dragonfly implementation path is a noop and not implemented.
Introduce a very basic sorted_map_test around Add and move the unrelated old test from sorted_map_test to bptree_set_test.