Skip to content

Conversation

royjacobson
Copy link
Contributor

No description provided.

@royjacobson royjacobson force-pushed the daily_coverage branch 12 times, most recently from 4c1fe97 to a24f034 Compare June 19, 2023 19:21
@kostasrim kostasrim force-pushed the daily_coverage branch 4 times, most recently from 866a59f to 4eca093 Compare June 20, 2023 20:23
@royjacobson royjacobson changed the title lets try Trying to add coverage CI flow Jun 21, 2023
@royjacobson royjacobson marked this pull request as ready for review August 14, 2023 16:26
@royjacobson royjacobson requested a review from kostasrim August 14, 2023 16:26
@royjacobson royjacobson changed the title Trying to add coverage CI flow chore: Add a daily coverage run Aug 14, 2023
- name: Upload coverage
uses: actions/upload-artifact@v3
with:
name: coverage-report
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@romange Roy told me that you figured out why we couldn't upload the coverage. Could you plz tell us here what the issue was ?

@kostasrim
Copy link
Contributor

Also I downloaded the produced artifact/ code coverage, everything seems to be ok!

@royjacobson royjacobson requested a review from kostasrim August 21, 2023 08:44
Copy link
Contributor

@kostasrim kostasrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 🇮🇹

@royjacobson royjacobson merged commit d12c6e3 into main Aug 22, 2023
@royjacobson royjacobson deleted the daily_coverage branch August 22, 2023 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants