fix: drain the connection socket on a protocol error #1422
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #1327.
To avoid the client
write
failing on a protocol error, meaning they never read the protocol error response, this closes only the servers send side of the connection (to send a FIN to the client but not an RST if the client keeps writing) then drains the client socket. So on the clientwrite
will still succeed, then they will receive the error protocol response.So in #1327, the client now receives
panic: Protocol error: invalid multibulk length
rather thanpanic: write tcp 127.0.0.1:42780->127.0.0.1:6379: write: connection reset by peer
.