Skip to content

fix: werror in ci and warning that slipped by #1297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 29, 2023
Merged

fix: werror in ci and warning that slipped by #1297

merged 3 commits into from
May 29, 2023

Conversation

royjacobson
Copy link
Contributor

I accidentally disabled -Werror when adding the Clang flow

@royjacobson royjacobson requested a review from chakaz May 28, 2023 11:15
chakaz
chakaz previously approved these changes May 28, 2023
View reviewed changes
@dranikpg
Copy link
Contributor

I see its a warning from search, will fix it

@royjacobson royjacobson merged commit 76801fa into main May 29, 2023
@romange romange deleted the fix_werror branch June 1, 2023 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@chakaz chakaz chakaz approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@royjacobson @dranikpg @chakaz