feat(cluster): Implement CLUSTER SHARDS.
#1284
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implementation includes support for both emulated mode and real cluster mode. Fixes #1276.
adiholden
reviewed
May 24, 2023
|
|
||
| auto vec = server_family_->GetDflyCmd()->GetReplicasRoleInfo(); | ||
| if (!vec.empty()) { | ||
| info.replicas.push_back({.id = etl.remote_client_id_, |
There was a problem hiding this comment.
why not for loop on vec?
There was a problem hiding this comment.
You're right. I copied from below. I'll also fix them later for the other commands.
adiholden
reviewed
May 24, 2023
src/server/cluster_family_test.cc
Outdated
| "nodes", // | ||
| RespArray(ElementsAre( // | ||
| RespArray(ElementsAre( // | ||
| "id", _, // |
There was a problem hiding this comment.
maybe compare the id to RunAdmin({"dflycluster", "myid"}) ?
There was a problem hiding this comment.
That's a good idea, once that command is merged in :)
There was a problem hiding this comment.
Oh, sorry, it's already merged in. I'll use it.
adiholden
approved these changes
May 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation includes support for both emulated mode and real cluster mode.
Implementation also includes a new test matcher and some monstrous
EXPECTstatements, reader be warned :)Fixes #1276.