chore: Try to turn on Werror in the CI #1261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dranikpg
approved these changes
May 21, 2023
Comment on lines
+15
to
+19
| # Disabled because it has false positives with ref-counted intrusive pointers. | ||
| CHECK_CXX_COMPILER_FLAG("-Wuse-after-free" HAS_USE_AFTER_FREE_WARN) | ||
| if (HAS_USE_AFTER_FREE_WARN) | ||
| set(CMAKE_CXX_FLAGS "-Wno-use-after-free ${CMAKE_CXX_FLAGS}") | ||
| endif() |
There was a problem hiding this comment.
For all? Or is it the false positive from helio's event count. Maybe we can surpress it somehow only for helio or even this exact case?
There was a problem hiding this comment.
It's tricky because you'd have to suppress it where the actual compilation error is emitted. Which in this case would be the first place after GCC loses track of the ref-counting and decides the pointer is deleted, so it could be a different call site each time.
It's a relatively new and complex warning, so I'm pretty Ok with disabling it for now.
romange
approved these changes
May 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's see if it works :)