Skip to content

Conversation

ArgoZhang
Copy link
Member

@ArgoZhang ArgoZhang commented Aug 19, 2025

Link issues

fixes #6647

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Bug Fixes:

  • Use the loop index variable in str.charCodeAt instead of a hard-coded value to correct hash code generation

@bb-auto bb-auto bot added the bug Something isn't working label Aug 19, 2025
@bb-auto bb-auto bot added this to the 9.9.0 milestone Aug 19, 2025
Copy link
Contributor

sourcery-ai bot commented Aug 19, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR corrects the hashCode utility by using the loop index when retrieving each character’s code to ensure proper hash calculations.

Class diagram for updated hashCode function

classDiagram
    class hashCode {
        +str: string
        +hash: number
        +char: number
        +for loop: uses index i to access str.charCodeAt(i)
    }
Loading

File-Level Changes

Change Details Files
Fixed hashCode calculation to use the loop index for char code retrieval
  • Replaced str.charCodeAt(1) with str.charCodeAt(i)
  • Ensured each character in the string contributes correctly to the hash
src/BootstrapBlazor/wwwroot/modules/utility.js

Assessment against linked issues

Issue Objective Addressed Explanation
#6647 Fix the bug in the hashCode function by using the index variable 'i' in str.charCodeAt(i) instead of a constant value.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes - here's some feedback:

  • Please update the PR title to reference hashCode instead of hasCode for clarity.
  • Add a concise summary in the PR description explaining this change to improve context for reviewers.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Please update the PR title to reference `hashCode` instead of `hasCode` for clarity.
- Add a concise summary in the PR description explaining this change to improve context for reviewers.

## Individual Comments

### Comment 1
<location> `src/BootstrapBlazor/wwwroot/modules/utility.js:673` </location>
<code_context>
 const hashCode = str => {
     let hash = 0;
     for (let i = 0; i < str.length; i++) {
-        const char = str.charCodeAt(1);
+        const char = str.charCodeAt(i);
         hash = (hash << 5) - hash + char;
         hash |= 0;
</code_context>

<issue_to_address>
The change from str.charCodeAt(1) to str.charCodeAt(i) fixes the hash function logic.

Using str.charCodeAt(i) ensures each character is included in the hash calculation, reducing collisions and improving hash quality.
</issue_to_address>

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link

codecov bot commented Aug 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (f13a950) to head (a8e70f8).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #6650   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          739       739           
  Lines        31674     31674           
  Branches      4459      4459           
=========================================
  Hits         31674     31674           
Flag Coverage Δ
BB 100.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(hasCode): use index variable
1 participant