Skip to content

Conversation

ArgoZhang
Copy link
Member

@ArgoZhang ArgoZhang commented Aug 13, 2025

Link issues

fixes #6612

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Refactor DialButton items to unify styling and markup, replace LinkButton components with Tooltip-wrapped anchors, update icons, and clean up obsolete CSS and assets.

Enhancements:

  • Replace LinkButton components for chat and update actions with Tooltip wrappers containing anchor elements
  • Consolidate button styles under a new .btn-dial-item CSS class and remove obsolete .btn-chat and .btn-update rules
  • Update the update button icon to fa-file-circle-check and remove the unused log.svg asset

@bb-auto bb-auto bot added the documentation Improvements or additions to documentation label Aug 13, 2025
@bb-auto bb-auto bot added this to the 9.9.0 milestone Aug 13, 2025
Copy link
Contributor

sourcery-ai bot commented Aug 13, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR refactors the dial button UI by replacing custom LinkButton components with Tooltip-wrapped anchor icons, consolidating CSS under a unified .btn-dial-item selector, and removing an obsolete image asset.

Class diagram for dial button item refactor

classDiagram
    class LinkButton {
        - TooltipPlacement
        - ButtonStyle
        - Color
        - TooltipText
        - class
        - Url
        - Icon
        - Target
        - ImageUrl
    }
    class Tooltip {
        - Title
        - Placement
        - class
    }
    class a {
        - href
        - target
    }
    class i {
        - class (icon)
    }
    LinkButton <|-- removed
    Tooltip "1" o-- "1" a : wraps
    a "1" o-- "1" i : contains
    %% LinkButton is removed from dial button items, replaced by Tooltip wrapping anchor and icon
Loading

File-Level Changes

Change Details Files
Refactor dial button components to use Tooltip wrappers and anchor icons
  • Replaced LinkButton for chat and update actions with Tooltip components
  • Wrapped FontAwesome icons inside tags for proper anchor behavior
  • Consolidated classes to btn btn-circle btn-fade btn-dial-item d-flex
src/BootstrapBlazor.Server/Components/Layout/MainLayout.razor
Consolidate and update CSS for dial buttons
  • Removed legacy .btn-update rules
  • Renamed .btn-chat to .btn-dial-item and unified style variables
  • Added nested selector for .btn-dial-item a to inherit text color
src/BootstrapBlazor.Server/Components/Layout/MainLayout.razor.css
Remove unused image asset
  • Deleted obsolete log.svg from wwwroot/images
src/BootstrapBlazor.Server/wwwroot/images/log.svg

Assessment against linked issues

Issue Objective Addressed Explanation
#6612 Add sample code for the DialButton component to the documentation. The PR updates the implementation and styling of the DialButton and its items, but does not add any sample code or documentation for the DialButton component.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@ArgoZhang ArgoZhang merged commit 7504bbd into main Aug 13, 2025
5 checks passed
@ArgoZhang ArgoZhang deleted the doc-link-button branch August 13, 2025 01:00
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArgoZhang - I've reviewed your changes - here's some feedback:

  • The update button is still using ChatTooltip for its Tooltip Title; please introduce a distinct tooltip text (e.g. UpdateTooltip) to avoid showing incorrect labels.
  • The repeated Tooltip > a > i markup pattern could be extracted into a small reusable component to reduce duplication and improve readability.
  • Consider adding aria-labels (or role="button") to the anchor or icon elements for better accessibility and screen reader support.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The update button is still using ChatTooltip for its Tooltip Title; please introduce a distinct tooltip text (e.g. UpdateTooltip) to avoid showing incorrect labels.
- The repeated Tooltip > a > i markup pattern could be extracted into a small reusable component to reduce duplication and improve readability.
- Consider adding aria-labels (or role="button") to the anchor or icon elements for better accessibility and screen reader support.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link

codecov bot commented Aug 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (7a6156e) to head (6722f9f).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #6613   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          739       739           
  Lines        31672     31672           
  Branches      4458      4458           
=========================================
  Hits         31672     31672           
Flag Coverage Δ
BB 100.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

doc(DialButton): update dial button
1 participant