Skip to content

Conversation

ArgoZhang
Copy link
Member

@ArgoZhang ArgoZhang commented Aug 11, 2025

Link issues

fixes #6589

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Bug Fixes:

  • Prevent header width overflow in DateTimePicker when ViewMode is DateTime by adding a dedicated CSS class and reducing the header label font size

@bb-auto bb-auto bot added the bug Something isn't working label Aug 11, 2025
@bb-auto bb-auto bot added this to the 9.9.0 milestone Aug 11, 2025
Copy link
Contributor

sourcery-ai bot commented Aug 11, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR resolves width overflow in DateTime view by introducing a dedicated header-bar class injected via C# logic and accompanying CSS tweaks to reduce the header label font size.

Class diagram for updated DatePickerBody header label logic

classDiagram
    class DatePickerBody {
        - bool IsDateTimeMode
        + string? HeaderLabelString
    }
    DatePickerBody : HeaderLabelString
    DatePickerBody : IsDateTimeMode
Loading

File-Level Changes

Change Details Files
Implement conditional header-bar class injection for DateTime mode
  • Add HeaderLabelString property using CssBuilder to toggle 'picker-panel-header-bar'
  • Replace static class attribute on header div with HeaderLabelString
  • Apply 'picker-panel-header-bar' when ViewMode is DateTime
src/BootstrapBlazor/Components/DateTimePicker/DatePickerBody.razor.cs
src/BootstrapBlazor/Components/DateTimePicker/DatePickerBody.razor
Adjust header label styling to prevent overflow
  • Add CSS rule to set .picker-panel-header-bar .picker-panel-header-label font-size to 14px
src/BootstrapBlazor/Components/DateTimePicker/DatePickerBody.razor.scss

Assessment against linked issues

Issue Objective Addressed Explanation
#6589 Fix the width overflow issue in DateTimePicker when time selection is enabled (ViewMode is DateTime).

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArgoZhang - I've reviewed your changes and they look great!

Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments

### Comment 1
<location> `src/BootstrapBlazor/Components/DateTimePicker/DatePickerBody.razor.scss:65` </location>
<code_context>
                     }
                 }

+                .picker-panel-header-bar {
+                    .picker-panel-header-label {
+                        font-size: 14px;
+                    }
+                }
</code_context>

<issue_to_address>
Check for style conflicts between .picker-panel-header-label font-size definitions.

There are conflicting font-size values (14px and 16px) for .picker-panel-header-label. Please confirm which value should take precedence to avoid inconsistent styling.
</issue_to_address>

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(DateTimePicker): 修复 DateTimePicker 开启时间时宽度溢出问题
1 participant