Skip to content

Conversation

ArgoZhang
Copy link
Member

@ArgoZhang ArgoZhang commented Aug 7, 2025

Link issues

fixes #6570

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Add support for the IsKeepDisabled parameter when rendering TableCellButton and TableCellPopConfirmButton components in table extension buttons

New Features:

  • Enable IsKeepDisabled binding on TableCellButton
  • Enable IsKeepDisabled binding on TableCellPopConfirmButton

@bb-auto bb-auto bot added the enhancement New feature or request label Aug 7, 2025
@bb-auto bb-auto bot added this to the 9.9.0 milestone Aug 7, 2025
Copy link
Contributor

sourcery-ai bot commented Aug 7, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR enhances TableExtensionButton by propagating the new IsKeepDisabled parameter to both TableCellButton and TableCellPopConfirmButton implementations, ensuring disabled state is preserved across async operations.

Class diagram for TableCellButton and TableCellPopConfirmButton with IsKeepDisabled parameter

classDiagram
    class TableCellButton {
        +bool IsKeepDisabled
        ...
    }
    class TableCellPopConfirmButton {
        +bool IsKeepDisabled
        ...
    }
    class TableExtensionButton {
        ...
    }
    TableExtensionButton --> TableCellButton : uses
    TableExtensionButton --> TableCellPopConfirmButton : uses
Loading

File-Level Changes

Change Details Files
propagate IsKeepDisabled to table cell buttons
  • bind IsKeepDisabled="b.IsKeepDisabled" on Button component
  • bind IsKeepDisabled="b.IsKeepDisabled" on PopConfirmButton component
src/BootstrapBlazor/Components/Table/TableExtensionButton.razor

Assessment against linked issues

Issue Objective Addressed Explanation
#6570 Add support for the IsKeepDisabled parameter to TableCellPopConfirmButton.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

sourcery-ai[bot]
sourcery-ai bot previously approved these changes Aug 7, 2025
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArgoZhang - I've reviewed your changes and they look great!

Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments

### Comment 1
<location> `src/BootstrapBlazor/Components/Table/TableExtensionButton.razor:14` </location>
<code_context>
                 <Button AdditionalAttributes="b.AdditionalAttributes" Size="b.Size"
-                        Color="@b.Color" Icon="@b.Icon" Text="@b.Text" IsAsync="@b.IsAsync"
+                        Color="@b.Color" Icon="@b.Icon" Text="@b.Text"
+                        IsAsync="@b.IsAsync" IsKeepDisabled="b.IsKeepDisabled"
                         TooltipText="@b.TooltipText" TooltipPlacement="@b.TooltipPlacement"
                         TooltipTrigger="@b.TooltipTrigger" ChildContent="@b.ChildContent"
</code_context>

<issue_to_address>
Potential variable mismatch: 'b.IsKeepDisabled' used in PopConfirmButton case.

'b' is not defined in this context; use 'pb.IsKeepDisabled' if that is the correct variable.
</issue_to_address>

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link

codecov bot commented Aug 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (8fe72a5) to head (33781bc).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #6571      +/-   ##
===========================================
+ Coverage   99.98%   100.00%   +0.01%     
===========================================
  Files         719       719              
  Lines       31566     31566              
  Branches     4452      4453       +1     
===========================================
+ Hits        31560     31566       +6     
+ Misses          4         0       -4     
+ Partials        2         0       -2     
Flag Coverage Δ
BB 100.00% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(TableCellPopConfirmButton): support IsKeepDisabled parameter
1 participant