-
-
Notifications
You must be signed in to change notification settings - Fork 355
feat(TableCellPopConfirmButton): support IsKeepDisabled parameter #6571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR enhances TableExtensionButton by propagating the new IsKeepDisabled parameter to both TableCellButton and TableCellPopConfirmButton implementations, ensuring disabled state is preserved across async operations. Class diagram for TableCellButton and TableCellPopConfirmButton with IsKeepDisabled parameterclassDiagram
class TableCellButton {
+bool IsKeepDisabled
...
}
class TableCellPopConfirmButton {
+bool IsKeepDisabled
...
}
class TableExtensionButton {
...
}
TableExtensionButton --> TableCellButton : uses
TableExtensionButton --> TableCellPopConfirmButton : uses
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes and they look great!
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `src/BootstrapBlazor/Components/Table/TableExtensionButton.razor:14` </location>
<code_context>
<Button AdditionalAttributes="b.AdditionalAttributes" Size="b.Size"
- Color="@b.Color" Icon="@b.Icon" Text="@b.Text" IsAsync="@b.IsAsync"
+ Color="@b.Color" Icon="@b.Icon" Text="@b.Text"
+ IsAsync="@b.IsAsync" IsKeepDisabled="b.IsKeepDisabled"
TooltipText="@b.TooltipText" TooltipPlacement="@b.TooltipPlacement"
TooltipTrigger="@b.TooltipTrigger" ChildContent="@b.ChildContent"
</code_context>
<issue_to_address>
Potential variable mismatch: 'b.IsKeepDisabled' used in PopConfirmButton case.
'b' is not defined in this context; use 'pb.IsKeepDisabled' if that is the correct variable.
</issue_to_address>
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6571 +/- ##
===========================================
+ Coverage 99.98% 100.00% +0.01%
===========================================
Files 719 719
Lines 31566 31566
Branches 4452 4453 +1
===========================================
+ Hits 31560 31566 +6
+ Misses 4 0 -4
+ Partials 2 0 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Link issues
fixes #6570
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Add support for the IsKeepDisabled parameter when rendering TableCellButton and TableCellPopConfirmButton components in table extension buttons
New Features: