Removing unnecessary comments in Fluent theme files #10988
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR removes redundant comments from Fluent theme files to clean up the codebase. The changes are purely cosmetic and focus on removing duplicate "Universal WPF UI focus" comments that were unnecessarily wrapping FocusVisualStyle setter properties.
- Removes duplicate "Universal WPF UI focus" comments from various control styles
- Affects multiple WPF controls including ComboBox, DataGrid, RadioButton, RepeatButton, ToggleButton, and TreeView components
- Spans across all Fluent theme variants (default, light, dark, and high contrast)
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Fluent.xaml | Removes redundant focus comments from main Fluent theme file |
| Fluent.Light.xaml | Removes redundant focus comments from Light theme variant |
| Fluent.HC.xaml | Removes redundant focus comments from High Contrast theme variant |
| Fluent.Dark.xaml | Removes redundant focus comments from Dark theme variant |
| TreeViewItem.xaml | Removes redundant focus comments from TreeViewItem style definitions |
| ToggleButton.xaml | Removes redundant focus comments from ToggleButton style definitions |
| RepeatButton.xaml | Removes redundant focus comments from RepeatButton style definitions |
| RadioButton.xaml | Removes redundant focus comments from RadioButton style definitions |
| DataGrid.xaml | Removes redundant focus comments from DataGrid style definitions |
| ComboBox.xaml | Removes redundant focus comments from ComboBox style definitions |
dotnet-policy-service
bot
added
the
PR
harshit7962
approved these changes
Jul 18, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10988 +/- ##
===================================================
- Coverage 13.52892% 13.52246% -0.00646%
===================================================
Files 3319 3319
Lines 664894 664894
Branches 74674 74674
===================================================
- Hits 89953 89910 -43
- Misses 572398 572440 +42
- Partials 2543 2544 +1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Particall fixes #8554
Description
In this PR, I have removed the extra comments regarding focus from the Fluent theme files. This is part of the work for #8554.
Customer Impact
--
Regression
NA
Testing
None
Risk
None
Microsoft Reviewers: Open in CodeFlow