Skip to content

Conversation

ViktorHofer
Copy link
Member

@ViktorHofer ViktorHofer commented Jul 9, 2025

Use the new paths feature and allow newer SDKs when building

https://learn.microsoft.com/en-us/dotnet/core/tools/global-json#paths

Use the new paths feature and allow newer SDKs when building
@Copilot Copilot AI review requested due to automatic review settings July 9, 2025 13:45
@ViktorHofer ViktorHofer requested a review from a team as a code owner July 9, 2025 13:45
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the global.json to use the new SDK “paths” feature, allow prerelease SDKs, and provide a custom error message when the required SDK isn’t found.

  • Introduces a top-level sdk section with version, allowPrerelease, rollForward, paths, and errorMessage properties
  • Removes the legacy nested sdk block under tools
  • Retains the tools.dotnet and tools.runtimes entries for tool resolution
Comments suppressed due to low confidence (3)

global.json:6

  • [nitpick] Consider adding a brief comment explaining the role of each path entry (e.g., why '.dotnet' and '$host$' are included) to aid future maintainers.
    "paths": [

global.json:10

  • Verify that the errorMessage property is supported by SDK version 10.0.100-preview.7.25322.101; if not, upgrade to a preview that includes custom error messages or remove this property.
    "errorMessage": "The required .NET SDK wasn't found. Please run ./eng/common/dotnet.cmd/sh to install it."

global.json:13

  • Since the SDK version is now declared at the top level, consider removing or documenting the tools.dotnet entry to avoid duplicate version configurations.
    "dotnet": "10.0.100-preview.7.25322.101",

@dotnet-policy-service dotnet-policy-service bot added the PR metadata: Label to tag PRs, to facilitate with triage label Jul 9, 2025
Copy link

codecov bot commented Jul 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 13.42064%. Comparing base (02d9559) to head (176641c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #10973         +/-   ##
===================================================
- Coverage   13.42379%   13.42064%   -0.00315%     
===================================================
  Files           3319        3319                 
  Lines         664894      664894                 
  Branches       74674       74674                 
===================================================
- Hits           89254       89233         -21     
- Misses        573097      573116         +19     
- Partials        2543        2545          +2     
Flag Coverage Δ
Debug 13.42064% <ø> (-0.00315%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@harshit7962 harshit7962 self-assigned this Jul 10, 2025
@harshit7962 harshit7962 merged commit 556b6b1 into main Jul 10, 2025
8 checks passed
@harshit7962 harshit7962 deleted the ViktorHofer-patch-1 branch July 10, 2025 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR metadata: Label to tag PRs, to facilitate with triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants