Skip to content

Conversation

Olina-Zhang
Copy link
Member

@Olina-Zhang Olina-Zhang commented Jul 18, 2025

Related #13442

Proposed changes

  • Add unit test file: ListViewItemStateImageIndexConverterTests.cs for ListViewItemStateImageIndexConverter.cs file
Microsoft Reviewers: Open in CodeFlow

Copy link

codecov bot commented Jul 18, 2025

Codecov Report

❌ Patch coverage is 86.11111% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.91036%. Comparing base (2932c39) to head (3abbdf8).
⚠️ Report is 30 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #13716         +/-   ##
===================================================
+ Coverage   76.82960%   76.91036%   +0.08075%     
===================================================
  Files           3257        3260          +3     
  Lines         642587      643124        +537     
  Branches       47564       47601         +37     
===================================================
+ Hits          493697      494629        +932     
+ Misses        145229      144832        -397     
- Partials        3661        3663          +2     
Flag Coverage Δ
Debug 76.91036% <86.11111%> (+0.08075%) ⬆️
integration 18.99069% <ø> (+0.00330%) ⬆️
production 51.58221% <ø> (+0.14070%) ⬆️
test 97.42038% <86.11111%> (+0.00215%) ⬆️
unit 48.97241% <ø> (+0.14598%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

LeafShi1
LeafShi1 previously approved these changes Jul 22, 2025
Copy link
Member

@LeafShi1 LeafShi1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dotnet-policy-service dotnet-policy-service bot added the waiting-author-feedback The team requires more information from the author label Jul 24, 2025
@dotnet-policy-service dotnet-policy-service bot removed the waiting-author-feedback The team requires more information from the author label Jul 25, 2025
Copy link
Member

@ricardobossan ricardobossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ricardobossan ricardobossan merged commit 2be1d3f into dotnet:main Jul 28, 2025
8 checks passed
@Olina-Zhang Olina-Zhang deleted the UnitTest_ListViewItemStateImageIndexConverter branch July 29, 2025 02:34
@github-actions github-actions bot locked and limited conversation to collaborators Aug 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants