Skip to content

Add do...while loop in the SetValue method of SerializationResourceManager.cs until resourceName is unique #13578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 16, 2025
Merged

Add do...while loop in the SetValue method of SerializationResourceManager.cs until resourceName is unique #13578

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
55afccb
Add do...while loop in the SetValue method of SerializationResourceMa…
LeafShi1 Jun 10, 2025
78091bf
Check nameBase directly rather than resourceName for clarity
LeafShi1 Jun 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions ...onentModel/Design/Serialization/ResourceCodeDomSerializer.SerializationResourceManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -778,10 +778,17 @@ public string SetValue(IDesignerSerializationManager manager, ExpressionContext?

// Only append the number when appendCount is set or if there is already a count.
int count = 0;
if (appendCount || _nameTable.TryGetValue(nameBase, out count))

if (appendCount || _nameTable.ContainsKey(nameBase))
{
count++;
resourceName = $"{nameBase}{count}";
_nameTable.TryGetValue(nameBase, out count);

do
{
count++;
resourceName = $"{nameBase}{count}";
}
while (_nameTable.ContainsKey(resourceName));
}

// Now that we have a name, write out the resource.
Expand Down