-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add code coverage for ListView.IconComparer #13485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ricardobossan
merged 2 commits into
dotnet:main
from
MelonWang1:Add_code_coverage_for_ListView.IconComparer
Jun 11, 2025
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
60 changes: 60 additions & 0 deletions
60
src/test/unit/System.Windows.Forms/System/Windows/Forms/ListView.IconComparerTests.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,60 @@ | ||
// Licensed to the .NET Foundation under one or more agreements. | ||
// The .NET Foundation licenses this file to you under the MIT license. | ||
|
||
namespace System.Windows.Forms.Tests; | ||
|
||
public class ListView_IconComparerTests | ||
{ | ||
[WinFormsTheory] | ||
[InlineData(SortOrder.Ascending)] | ||
[InlineData(SortOrder.Descending)] | ||
[InlineData(SortOrder.None)] | ||
public void Constructor_SetsSortOrder_Correctly(SortOrder order) | ||
{ | ||
ListView.IconComparer comparer = new(order); | ||
|
||
((SortOrder)comparer.TestAccessor().Dynamic._sortOrder).Should().Be(order); | ||
} | ||
|
||
[WinFormsTheory] | ||
[InlineData(SortOrder.Ascending, SortOrder.Descending)] | ||
[InlineData(SortOrder.Descending, SortOrder.Ascending)] | ||
[InlineData(SortOrder.None, SortOrder.Ascending)] | ||
public void SortOrder_Setter_UpdatesSortOrder(SortOrder initialOrder, SortOrder updatedOrder) | ||
{ | ||
ListView.IconComparer comparer = new(initialOrder) | ||
{ | ||
SortOrder = updatedOrder | ||
}; | ||
|
||
((SortOrder)comparer.TestAccessor().Dynamic._sortOrder).Should().Be(updatedOrder); | ||
} | ||
|
||
[WinFormsTheory] | ||
[InlineData(SortOrder.Ascending, "A", "B", -1)] | ||
[InlineData(SortOrder.Ascending, "B", "A", 1)] | ||
[InlineData(SortOrder.Ascending, "A", "A", 0)] | ||
[InlineData(SortOrder.Descending, "A", "B", 1)] | ||
[InlineData(SortOrder.Descending, "B", "A", -1)] | ||
[InlineData(SortOrder.Descending, "A", "A", 0)] | ||
public void Compare_ComparesListViewItems_ByText_AndSortOrder(SortOrder order, string text1, string text2, int expectedSign) | ||
{ | ||
ListView.IconComparer comparer = new(order); | ||
ListViewItem item1 = new(text1); | ||
ListViewItem item2 = new(text2); | ||
int result = comparer.Compare(item1, item2); | ||
|
||
Math.Sign(result).Should().Be(expectedSign); | ||
} | ||
|
||
[WinFormsFact] | ||
public void Compare_NullItems_ReturnsExpected() | ||
{ | ||
ListView.IconComparer comparer = new(SortOrder.Ascending); | ||
ListViewItem item = new("A"); | ||
|
||
comparer.Compare(null, null).Should().Be(0); | ||
comparer.Compare(null, item).Should().BeLessThan(0); | ||
comparer.Compare(item, null).Should().BeGreaterThan(0); | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.