Add proper working ToolStripMenuItem controls to DropDownItems
#13065
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes dotnet#12987 - Added strings to `DropDownItems` instead of adding controls. - Add proper working `ToolStripMenuItem` controls to `DropDownItems`. - Interaction with `DemoConsole` fixed `DropDownItems` will be possible. - No - Minimal - Manual - 10.0.100-preview.3.25125.5
ricardobossan
added
the
waiting-review
ricardobossan
requested review from
Tanya-Solyanik,
LeafShi1,
Epica3055 and
Copilot
There was a problem hiding this comment.
PR Overview
This PR fixes bug #12987 by replacing the addition of plain string items in DropDownItems with properly instantiated ToolStripMenuItem controls to enhance menu interaction in the DemoConsole.
- Replace string entries with ToolStripMenuItem objects
- Update the text for dropdown items to correct previous typos
Reviewed Changes
| File | Description |
|---|---|
| src/System.Windows.Forms/tests/IntegrationTests/DesignSurface/DemoConsole/MainForm.cs | Updated to add proper ToolStripMenuItem controls to DropDownItems |
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Tanya-Solyanik
approved these changes
Mar 3, 2025
Tanya-Solyanik
removed
the
waiting-review
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13065 +/- ##
====================================================
- Coverage 96.95044% 76.13835% -20.81209%
====================================================
Files 1225 3275 +2050
Lines 357134 643803 +286669
Branches 5537 47445 +41908
====================================================
+ Hits 346243 490181 +143938
- Misses 10049 150062 +140013
- Partials 842 3560 +2718
Flags with carried forward coverage won't be shown. Click here to find out more. |
LeafShi1
pushed a commit
to LeafShi1/winforms
that referenced
this pull request
Mar 6, 2025
…otnet#13065) Add proper working `ToolStripMenuItem` controls to `DropDownItems`. Fixes dotnet#12987 - Added strings to `DropDownItems` instead of adding controls. - Add proper working `ToolStripMenuItem` controls to `DropDownItems`. - Interaction with `DemoConsole` fixed `DropDownItems` will be possible. - No - Minimal - Manual - 10.0.100-preview.3.25125.5 Co-authored-by: Ricardo Bossan (BEYONDSOFT CONSULTING INC) (from Dev Box) <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12987
Root Cause
DropDownItemsinstead of adding controls.Proposed changes
ToolStripMenuItemcontrols toDropDownItems.Customer Impact
DemoConsolefixedDropDownItemswill be possible.Regression?
Risk
Screenshots
Before
After
Test methodology
Test environment(s)
Microsoft Reviewers: Open in CodeFlow