Remove autoconvert from SetDataAsJson #13060
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The autoconvert argument doesn't make sense when setting data as JSON as the only place this has any impact is with a fixed set of predefined formats (text for example). You shouldn't be setting known formats with this method. Also add a more extensive comment to `TryUnwrapUserDataObject`.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13060 +/- ##
====================================================
- Coverage 96.95044% 76.10527% -20.84517%
====================================================
Files 1225 3275 +2050
Lines 357134 643803 +286669
Branches 5537 47445 +41908
====================================================
+ Hits 346243 489968 +143725
- Misses 10049 150280 +140231
- Partials 842 3555 +2713
Flags with carried forward coverage won't be shown. Click here to find out more. |
Tanya-Solyanik
approved these changes
Mar 3, 2025
src/System.Private.Windows.Core/src/System/Private/Windows/Ole/IDataObjectInternal.cs
Show resolved
Hide resolved
src/System.Private.Windows.Core/src/System/Private/Windows/Ole/IDataObjectInternal.cs
Show resolved
Hide resolved
LeafShi1
pushed a commit
to LeafShi1/winforms
that referenced
this pull request
Mar 6, 2025
The autoconvert argument doesn't make sense when setting data as JSON as the only place this has any impact is with a fixed set of predefined formats (text for example). You shouldn't be setting known formats with this method. Also add a more extensive comment to `TryUnwrapUserDataObject`.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The autoconvert argument doesn't make sense when setting data as JSON as the only place this has any impact is with a fixed set of predefined formats (text for example). You shouldn't be setting known formats with this method.
Also add a more extensive comment to
TryUnwrapUserDataObject.Microsoft Reviewers: Open in CodeFlow