Add .NET 6.0 TFM to packages #4640
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ericstj, can you comment on whether we need to add net6.0 to the Ref projects too? This work is to make the latest Xamarin platform which is based on .NET 6.0 (as opposed to mono) to use the WCF runtime assets from our packages instead of the previous Xamarin in-box mono based implementation. |
|
Yes we do need them in the Ref projects too since the packages contain |
|
@mconnew this should be good to go now, Eric gave his thumbs up :) |
|
Yes, to state explicitly: please make parallel changes to TFM additions in ref/src. You need both here. |
mconnew
approved these changes
Jul 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4237
See dotnet/designs#222 (comment) for context.
@mconnew I verified these packages restore using the
net6.0assets in the HelloAndroid sample from https://github.com/dotnet/maui-samples and at least a basic call to a SOAP webservice works.