Samples Revamp: ML - Batch Sentiment Analysis #320
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update personal master branch of fork
Update fork's master branch
suhsteve
reviewed
Oct 29, 2019
examples/Microsoft.Spark.CSharp.Examples/Sql/MachineLearning/SentimentAnalysis.cs
Outdated
Show resolved
Hide resolved
examples/Microsoft.Spark.CSharp.Examples/Sql/MachineLearning/SentimentAnalysis.cs
Outdated
Show resolved
Hide resolved
suhsteve
reviewed
Oct 30, 2019
examples/Microsoft.Spark.CSharp.Examples/Sql/MachineLearning/SentimentAnalysis.cs
Outdated
Show resolved
Hide resolved
examples/Microsoft.Spark.CSharp.Examples/Sql/MachineLearning/SentimentAnalysis.cs
Outdated
Show resolved
Hide resolved
ML.NET working in separate project, and other examples still build/compile successfully
Items related to previous version before creating separate project for this app
Reflect most recent folder hierarchy
Since each ML project will have its own folder/solution, can just name their readme's more generally "README.md"
ReviewText instead of Column1, Sentiment instead of Column2
Co-Authored-By: Steve Suh <[email protected]>
Co-Authored-By: Steve Suh <[email protected]>
Co-Authored-By: Steve Suh <[email protected]>
suhsteve
reviewed
Nov 12, 2019
examples/Microsoft.Spark.CSharp.Examples/MachineLearning/Sentiment/Program.cs
Outdated
Show resolved
Hide resolved
examples/Microsoft.Spark.CSharp.Examples/MachineLearning/Sentiment/README.md
Outdated
Show resolved
Hide resolved
Co-Authored-By: Steve Suh <[email protected]>
Want to avoid Path.Combine()
imback82
reviewed
Nov 15, 2019
examples/Microsoft.Spark.CSharp.Examples/MachineLearning/Sentiment/Program.cs
Outdated
Show resolved
Hide resolved
examples/Microsoft.Spark.CSharp.Examples/MachineLearning/Sentiment/Program.cs
Outdated
Show resolved
Hide resolved
|
|
||
| Depending upon the algorithm Model Builder chooses for your ML model, you may need to add an additional nuget reference in [Microsoft.Spark.CSharp.Examples.csproj](../../Microsoft.Spark.CSharp.Examples.csproj). For instance, if you get an error message that Microsoft.ML.FastTree cannot be found when running your Spark app, you need to add that nuget to your csproj file: | ||
|
|
||
| `<PackageReference Include="Microsoft.ML.FastTree" Version="1.3.1" />` |
There was a problem hiding this comment.
this seems different from what we are referencing in our csproj?
There was a problem hiding this comment.
Steve and I learned that depending on what algorithm is used in the model, you may have to add a different reference in your .csproj. Originally we needed FastTree, but once I changed to a new model that used a different algorithm, it no longer used FastTree and thus we could just reference Microsoft.ML. In case users train and use their own model and then run into issues, we wanted to add this explanation.
examples/Microsoft.Spark.CSharp.Examples/MachineLearning/Sentiment/Program.cs
Outdated
Show resolved
Hide resolved
imback82
approved these changes
Nov 16, 2019
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Add new batch sentiment analysis sample app & readme
-Add Machine Learning folder, and readme folder within it
-Add readme for Machine Learning folder
-Add reference to ML.NET v1.3.1 in C# csproj file