Add System.Formats.Asn1.6.0.1

[ellahathaway]

Related to dotnet/source-build#4518

Testing in this build (internal Microsoft link) (updated link)

[ellahathaway]

In testing, a prebuilt occurred for System.Formats.Asn1.6.0.0:

  <Usages>
    <Usage Id="System.Formats.Asn1" Version="6.0.0" File="src/source-build-reference-packages/artifacts/buildObj/obj/Microsoft.Build.Tasks.Core.17.3.4/project.assets.json" />
    <Usage Id="System.Formats.Asn1" Version="6.0.0" File="src/source-build-reference-packages/artifacts/buildObj/obj/Microsoft.Build.Tasks.Core.17.4.0/project.assets.json" />
    <Usage Id="System.Formats.Asn1" Version="6.0.0" File="src/source-build-reference-packages/artifacts/buildObj/obj/NuGet.Commands.6.8.1/project.assets.json" />
    <Usage Id="System.Formats.Asn1" Version="6.0.0" File="src/source-build-reference-packages/artifacts/buildObj/obj/NuGet.Credentials.6.8.1/project.assets.json" />
    <Usage Id="System.Formats.Asn1" Version="6.0.0" File="src/source-build-reference-packages/artifacts/buildObj/obj/NuGet.DependencyResolver.Core.6.8.1/project.assets.json" />
    <Usage Id="System.Formats.Asn1" Version="6.0.0" File="src/source-build-reference-packages/artifacts/buildObj/obj/NuGet.Packaging.6.8.1/project.assets.json" />
    <Usage Id="System.Formats.Asn1" Version="6.0.0" File="src/source-build-reference-packages/artifacts/buildObj/obj/NuGet.ProjectModel.6.8.1/project.assets.json" />
    <Usage Id="System.Formats.Asn1" Version="6.0.0" File="src/source-build-reference-packages/artifacts/buildObj/obj/NuGet.Protocol.6.8.1/project.assets.json" />
    <Usage Id="System.Formats.Asn1" Version="6.0.0" File="src/source-build-reference-packages/artifacts/buildObj/obj/System.Security.Cryptography.Xml.6.0.1/project.assets.json" />
  </Usages>

[ellahathaway]

Tested with an updated Build.props that includes the packages using the System.Formats.Asn1.6.0.0 prebuilt, and the build still had the prebuilt.

[ellahathaway]

@MichaelSimons - The prebuilt only occurs when building the VMR, so I'm assuming that to resolve this, we would have to upload the prebuilts tarball to get a clean build. If this is the case, there are two questions that I have:

1. Why does the prebuilt only occur in the VMR? Is it because the PSB artifacts use System.Formats.Asn1.6.0.0?
2. After uploading the prebuilts tarball, would we have to rebootstrap in order to eventually remove the tarball?

[MichaelSimons]

@MichaelSimons - The prebuilt only occurs when building the VMR, so I'm assuming that to resolve this, we would have to upload the prebuilts tarball to get a clean build. If this is the case, there are two questions that I have:

1. Why does the prebuilt only occur in the VMR? Is it because the PSB artifacts use System.Formats.Asn1.6.0.0?
2. After uploading the prebuilts tarball, would we have to rebootstrap in order to eventually remove the tarball?

The reason prebuilts are reported is because the SBRP build is free to use the N-1 artifacts. It is picking up packages from it that still have the Asn1.6.0.0 references. You may be able to workaround this issue by including the entire SBRP graph that depends on Asn1.6.0.0/1 as a DependencyPackageProjects in the correct order. Otherwise you would have to do this as a multi-step fix. Add Asn1.6.0.1, rebootstrap/update the SBRP self ref, and then remove Asn1.6.0.0

[ellahathaway]

You may be able to workaround this issue by including the entire SBRP graph that depends on Asn1.6.0.0/1 as a DependencyPackageProjects in the correct orde

I tried that approach in this build and still encountered the prebuilt, so I'll try your other suggested approach to include 6.0.0 and 6.0.1, rebootstrap & update, then remove 6.0.0. It might make sense avoid a manual rebootstrap and just wait until the next release since this issue also occurs in 8.0. That way, I can close the issue for 8.0 and main at the same time.

Thanks for your help!