Take two on copying dmp properly on posix #46111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous version apparently extended to:
find . -name *hangdump.dmp -exec cp {} /datadisks/disk1/work/A990088E/w/A95709AA/uploads /
The dmp was at:
/datadisks/disk1/work/A990088E/w/A95709AA/e/c6594614-4208-4b0b-b54d-967fbddc3173/dotnet_26747_20250118T001243_hangdump.dmp
So taking the env var and appending '..' should do the trick.
I'd be interested in seeing where '.' currently is, but I'd rather have this work now than add a pwd call then wait for it to fail again.
ghost
added
nagilson
approved these changes
Jan 21, 2025
|
If you plan on utilizing this fix in main today, it might be worth porting now. |
It should work its way forward, and I'd rather have at least a little validation (i.e., something fails in a 2xx build, and we get dumps) before porting everywhere optimistically |
|
@Forgind Looks like this may still not be working: From https://helixr1107v0xdeko0k025g8.blob.core.windows.net/dotnet-sdk-refs-pull-46183-merge-a9954070d559475e84/dotnet-watch.Tests.dll.5/1/console.774f1b97.log?helixlogtype=result, which was from #46183 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous version apparently extended to:
find . -name *hangdump.dmp -exec cp {} /datadisks/disk1/work/A990088E/w/A95709AA/uploads /
The dmp was at:
/datadisks/disk1/work/A990088E/w/A95709AA/e/c6594614-4208-4b0b-b54d-967fbddc3173/dotnet_26747_20250118T001243_hangdump.dmp
So taking the env var and appending '..' should do the trick.
I'd be interested in seeing where '.' currently is, but I'd rather have this work now than add a pwd call then wait for it to fail again.
Helix file I inspected:
https://helixr1107v0xd1eu3ibi6ka.blob.core.windows.net/dotnet-sdk-refs-pull-45880-merge-90fdd365f73d4e9694/dotnet-watch.Tests.dll.1/1/console.9e9600b2.log?helixlogtype=result