Remove 'NETSDK1219' warning #45538
Merged
Remove 'NETSDK1219' warning #45538
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Sergio0694
force-pushed
the
user/sergiopedri/uwp-net9-ga
branch
2 times, most recently
from
f780b53 to
258d5d3
Compare
Sergio0694
force-pushed
the
user/sergiopedri/uwp-net9-ga
branch
from
258d5d3 to
d6fd636
Compare
Sergio0694
force-pushed
the
user/sergiopedri/uwp-net9-ga
branch
from
0421f5b to
96fa393
Compare
marcpopMSFT
approved these changes
Jan 10, 2025
Member
|
Discussed offline and we're not locking down for QB approval until Monday so merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #41936
Summary
This PR removes the 'NETSDK1219' warning, effectively making UWP .NET 9 support GA. This warning has been added to signal that UWP support for .NET 9 was in preview, as all other components and tooling was also still work in progress (eg. Windows SDK changes for the XAML compiler, Visual Studio support, etc.). Now that all that tooling has shipped in stable (or, will have shipped in stable by the time this PR is published), we can remove this warning and officially mark the feature as GA.
Doing so is also needed to ensure customers on .NET Native can confidently start the migration away from .NET Native.
Customer Impact
No customer impact, this PR is only removing a warning.
Regression?
No.
Testing
Updated unit tests to ensure the new warning is gone.
Risk
Low. This is just removing a target whose sole purpose was to emit a warning.