Add default feature switch. #16766
Merged
Add default feature switch. #16766
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the EnableUnsafeBinaryFormatterInDesigntimeLicenseContextSerialization feature switch and default it to false for trimmed apps.
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
eerhardt
reviewed
Apr 6, 2021
src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.targets
Outdated
Show resolved
Hide resolved
Maybe we should rename this test to not be
Refers to: src/Tests/Microsoft.NET.Publish.Tests/GivenThatWeWantToRunILLink.cs:602 in ae95e4c. [](commit_id = ae95e4c, deletion_comment = False) |
pgovind
commented
Apr 6, 2021
src/Tests/Microsoft.NET.Publish.Tests/GivenThatWeWantToPublishAProjectWithAllFeatures.cs
Show resolved
Hide resolved
eerhardt
approved these changes
Apr 6, 2021
pgovind
added
auto-merge
|
Hello @pgovind! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the EnableUnsafeBinaryFormatterInDesigntimeLicenseContextSerialization feature switch and default it to false for trimmed apps. This is a follow up to dotnet/runtime#48527
I lifted the relevant patterns from https://github.com/dotnet/sdk/pull/15702/files. I don't know how to test these changes though, so I'd appreciate if someone told me how to test this locally!