Skip to content

[HTTP/3] Revert msquic hack in stress tests #87926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

[HTTP/3] Revert msquic hack in stress tests #87926

wants to merge 3 commits into from

Conversation

@ManickaP
Copy link
Member

@ManickaP ManickaP commented Jun 22, 2023

Revert #84793

cc @antonfirsov

@ghost ghost added the area-System.Net.Http label Jun 22, 2023
@ghost ghost assigned ManickaP Jun 22, 2023
@ghost
Copy link

ghost commented Jun 22, 2023

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Revert #84793

cc @antonfirsov

Author: ManickaP
Assignees: -
Labels:

area-System.Net.Http
Milestone: -

@ManickaP ManickaP mentioned this pull request Jun 22, 2023
Closed
@ManickaP
Copy link
Member Author

ManickaP commented Jun 22, 2023

/azp run runtime-libraries stress-http

@azure-pipelines
Copy link

azure-pipelines bot commented Jun 22, 2023

Azure Pipelines successfully started running 1 pipeline(s).

@ManickaP ManickaP requested review from a team, CarnaViire, antonfirsov, rzikm and wfurt June 22, 2023 14:20
@build-analysis build-analysis bot mentioned this pull request Jun 22, 2023
Closed
antonfirsov
antonfirsov approved these changes Jun 22, 2023
View reviewed changes
Copy link
Contributor

@antonfirsov antonfirsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

To me it looks like the timeouts in the PR are very similar to the ones we see with the hack:
https://dev.azure.com/dnceng-public/public/_build/results?buildId=311116&view=logs&j=22fea640-1099-5f32-ec5d-316ad83f359a&t=a923b061-8445-5c16-cd6e-848990587cb0

We also have #87938 which appeared recently. No idea whether it's related to the hack, I guess we'll know soon.

@ManickaP ManickaP mentioned this pull request Jun 23, 2023
Closed
@ManickaP
Copy link
Member Author

ManickaP commented Jun 23, 2023

/azp run runtime-libraries stress-http

@azure-pipelines
Copy link

azure-pipelines bot commented Jun 23, 2023

Azure Pipelines successfully started running 1 pipeline(s).

@ManickaP
Copy link
Member Author

ManickaP commented Jun 23, 2023

/azp run runtime-libraries stress-http

@azure-pipelines
Copy link

azure-pipelines bot commented Jun 23, 2023

Azure Pipelines successfully started running 1 pipeline(s).

@ManickaP ManickaP added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Jun 23, 2023
@ManickaP
Copy link
Member Author

ManickaP commented Jun 23, 2023

This will probably get closed as this is not the culprit. Working on #87957 instead.

@ManickaP
Copy link
Member Author

ManickaP commented Jun 26, 2023

Closing in favor of #87971

@ManickaP ManickaP closed this Jun 26, 2023
@karelz karelz added this to the 8.0.0 milestone Jul 3, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Aug 2, 2023
@ManickaP ManickaP deleted the mapichov/http3-stress-quic-hack-revert branch August 14, 2023 07:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@wfurt wfurt wfurt approved these changes

@rzikm rzikm Awaiting requested review from rzikm

@CarnaViire CarnaViire Awaiting requested review from CarnaViire

+1 more reviewer

@antonfirsov antonfirsov antonfirsov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ManickaP ManickaP

Labels

area-System.Net.Http NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons)

Projects

None yet

Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@ManickaP @antonfirsov @wfurt @karelz