Reserving two diagnostic codes for serialization work #84439
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrabYourPitchforks
force-pushed
the
bf_obs_3
branch
from
ddbea8d to
ba234d2
Compare
ghost
assigned
|
Tagging subscribers to this area: @dotnet/area-meta Issue DetailsSplit out from #84383 so that it can be fast-tracked. Reserves obsoletion diagnostic codes while the main PR is under review to help minimize the risk of conflicts.
|
jeffhandley
approved these changes
Apr 6, 2023
Member
jeffhandley
left a comment
jeffhandley
left a comment
There was a problem hiding this comment.
This wasn't the first time we've had conflicts arise while obsoleting things. I'll send a PR to augment the obsoletions docs to recommend this approach be taken generally.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split out from #84383 so that it can be fast-tracked. Reserves obsoletion diagnostic codes while the main PR is under review to help minimize the risk of conflicts.