Skip to content

[browser] cleanup of early startup code #83411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 28, 2023
Merged

[browser] cleanup of early startup code #83411

merged 6 commits into from
Apr 28, 2023

Conversation

@pavelsavara
Copy link
Member

@pavelsavara pavelsavara commented Mar 14, 2023 •
edited
Loading

Split off from #83364
Contributes to #72990
Contributes to #85045

  • drop dotnet.es6.post.js
  • simplify dotnet.es6.lib.js and dotnet.es6.extpost.js and dotnet.es6.pre.js
  • create types-api.ts by moving types from other files
  • drop export_linker() from startup
  • drop IMPORTS object
  • drop isGlobal flag (CJS cleanup)
  • reorganized init_polyfills_async and init_replacements
  • refactored unifyModuleConfig from dotnet.es6.pre.js to run-outer.ts
  • removed INTERNAL from top most export

@pavelsavara pavelsavara added this to the 8.0.0 milestone Mar 14, 2023
@pavelsavara pavelsavara requested a review from maraf March 14, 2023 18:55
@pavelsavara pavelsavara self-assigned this Mar 14, 2023
@ghost
Copy link

ghost commented Mar 14, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Split off from #83364

  • drop dotnet.es6.post.js and dotnet.es6.pre.js
  • simplify dotnet.es6.lib.js and dotnet.es6.extpost.js
  • create types-api.ts by moving types from other files
  • drop export_linker() from startup
  • drop IMPORTS object
  • drop isGlobal flag (CJS cleanup)
  • reorganized init_polyfills_async and init_replacements
  • moved createDotnetRuntime from dotnet.es6.pre.js to run-outer.ts
  • removed INTERNAL from top most export
Author: pavelsavara
Assignees: pavelsavara
Labels:

arch-wasm, area-System.Runtime.InteropServices.JavaScript
Milestone: 8.0.0

This was referenced Mar 14, 2023
Closed
Closed
Closed
Closed
@pavelsavara pavelsavara force-pushed the browser_modules_prep1 branch from 5c249d2 to 2e48725 Compare March 16, 2023 00:21
@build-analysis build-analysis bot mentioned this pull request Mar 16, 2023
Closed
@pavelsavara
Copy link
Member Author

pavelsavara commented Mar 16, 2023

/azp run runtime-wasm

@azure-pipelines
Copy link

azure-pipelines bot commented Mar 16, 2023

Azure Pipelines successfully started running 1 pipeline(s).

@pavelsavara
Copy link
Member Author

pavelsavara commented Mar 17, 2023

@radical I would appreciate your help with Wasm.Build.Tests on this branch. There are CI failures, but locally it works for me.

@pavelsavara
Copy link
Member Author

pavelsavara commented Mar 17, 2023

/azp run runtime-wasm

@azure-pipelines
Copy link

azure-pipelines bot commented Mar 17, 2023

Azure Pipelines successfully started running 1 pipeline(s).

@pavelsavara pavelsavara force-pushed the browser_modules_prep1 branch from 44d307b to 722e19b Compare April 14, 2023 09:17
@pavelsavara pavelsavara reopened this Apr 14, 2023
@build-analysis build-analysis bot mentioned this pull request Apr 14, 2023
Closed
@pavelsavara pavelsavara force-pushed the browser_modules_prep1 branch from ca3546e to d997a31 Compare April 18, 2023 17:51
This was referenced Apr 24, 2023
Closed
Closed
Closed
Closed
@pavelsavara pavelsavara force-pushed the browser_modules_prep1 branch from 937473f to 5ca2e17 Compare April 25, 2023 11:49
@pavelsavara
Copy link
Member Author

pavelsavara commented Apr 25, 2023

/azp run runtime-wasm

@azure-pipelines
Copy link

azure-pipelines bot commented Apr 25, 2023

Azure Pipelines successfully started running 1 pipeline(s).

@pavelsavara pavelsavara force-pushed the browser_modules_prep1 branch from 964b98f to 54e9f48 Compare April 26, 2023 12:42
@build-analysis build-analysis bot mentioned this pull request Apr 26, 2023
Closed
@pavelsavara pavelsavara force-pushed the browser_modules_prep1 branch from 54e9f48 to 55edc8b Compare April 26, 2023 15:32
@pavelsavara pavelsavara marked this pull request as ready for review April 27, 2023 12:18
@pavelsavara
Copy link
Member Author

pavelsavara commented Apr 27, 2023

/azp run runtime-wasm

@azure-pipelines
Copy link

azure-pipelines bot commented Apr 27, 2023

Azure Pipelines successfully started running 1 pipeline(s).

@build-analysis build-analysis bot mentioned this pull request Apr 27, 2023
Closed
@pavelsavara
Copy link
Member Author

pavelsavara commented Apr 27, 2023

All the CI failures are unrelated.

maraf
maraf reviewed Apr 28, 2023
View reviewed changes
Copy link
Member

@maraf maraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great! I have just some minor questions

@pavelsavara
Merge branch 'main' into browser_modules_prep1
20ffeb1
@pavelsavara
- maraf's feedback
8dad84d 
- renamed imports.ts to globals.ts
- formatted jiterp code
@pavelsavara
Copy link
Member Author

pavelsavara commented Apr 28, 2023

/azp run runtime-wasm

@azure-pipelines
Copy link

azure-pipelines bot commented Apr 28, 2023

Azure Pipelines successfully started running 1 pipeline(s).

maraf
maraf approved these changes Apr 28, 2023
View reviewed changes
Copy link
Member

@maraf maraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@pavelsavara pavelsavara merged commit e6924ee into dotnet:main Apr 28, 2023
@ghost ghost locked as resolved and limited conversation to collaborators May 28, 2023
@pavelsavara pavelsavara deleted the browser_modules_prep1 branch September 2, 2024 15:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@maraf maraf maraf approved these changes

@thaystg thaystg Awaiting requested review from thaystg

@radical radical Awaiting requested review from radical

@lewing lewing Awaiting requested review from lewing lewing is a code owner

@kg kg Awaiting requested review from kg

Assignees

@pavelsavara pavelsavara

Labels

arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript

Projects

None yet

Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@pavelsavara @maraf